fix(parsers): expand static dependency indirection coverage#826
Merged
fix(parsers): expand static dependency indirection coverage#826
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildSrcand version catalogs by resolving same-file literal assignments,ext { ... }properties, and nearbygradle.propertiesvalues used through$name,${name}, and Kotlinval ... by projectinterpolationPodfileparsing to follow bounded localrequire_relativehelpers and recover version arguments from simple Ruby hash lookups such asversions['Flipper']$(Property)replacements to embedded and chained MSBuild property expansion, then apply that to PackageReference versions and project metadata[...].join('.')version buildersScope and exclusions
src/parsers/gradle.rsplus new/updated goldens undertestdata/gradle-golden/src/parsers/podfile.rsplus a new Podfile golden undertestdata/cocoapods-golden/podfile/with-required-version-hash/src/parsers/nuget/utils.rs,src/parsers/nuget/project_file.rs, and a new PackageReference golden undertestdata/nuget-golden/package-reference-interpolation/src/parsers/ruby.rsplus a new gemspec golden undertestdata/ruby-golden/interpolated-constants/Intentional differences from Python
build.gradle[.kts]plus nearbygradle.properties) without evaluating Gradle.$(VersionPrefix)-$(VersionSuffix)when those values are statically available in the project file.Follow-up work
cargo test test_gradle_properties_and_local_assignments_resolve_interpolationcargo test test_extract_pod_version_from_required_hashcargo test test_csproj_package_reference_resolves_embedded_property_versionscargo test test_extract_gemspec_required_file_interpolated_constantscargo test --features golden-tests test_golden_kotlin_project_propertiescargo test --features golden-tests test_golden_groovy6_with_propscargo test --features golden-tests test_golden_podfile_required_version_hashcargo test --features golden-tests test_golden_package_reference_project_with_property_interpolationcargo test --features golden-tests test_golden_interpolated_constants_gemspeccargo test parsers::gradle::tests::cargo test parsers::podfile::tests::cargo test parsers::nuget::nuget_test::tests::cargo test parsers::ruby_test::tests::Expected-output fixture changes
testdata/gradle-golden/groovy/groovy6-with-props/build.gradle-expected.jsontestdata/gradle-golden/kotlin/project-properties/build.gradle.kts-expected.jsontestdata/cocoapods-golden/podfile/with-required-version-hash/Podfile-expected.jsontestdata/nuget-golden/package-reference-interpolation/IceRpc.Examples.csproj.expectedtestdata/ruby-golden/interpolated-constants/interpolated_constants.gemspec.expected