fix(nuget): tighten bounded CPM props resolution#827
Merged
Conversation
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
547e9e0 to
4044787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Directory.Packages.props/Directory.Build.propsimport following to the actual active scan root and deny out-of-scope.propsreads.propscentral package versions during assembly while keeping partially unresolved composed expressions unresolveddocs/BENCHMARKS.mdwith refreshed standalonedotnet/extensionsand newmicrosoft/regoruscompare-output snapshotsIssues
Scope and exclusions
src/parsers/mod.rs,src/scanner/collect.rs, andsrc/scanner/process/orchestrator.rs.propsimport/path handling and composed property resolution insrc/parsers/nuget/andsrc/assembly/nuget_cpm_resolve.rsmicrosoft/regorus @ 7f42115from.provenant/compare-runs/20260430T114610Z-regorus-348dotnet/extensions @ 7171956refresh from.provenant/compare-runs/20260430T115315Z-extensions-9749PropertyGrouporItemGroupevaluation beyond the existing bounded behaviorDirectory.Build.targets, wildcard imports, or arbitrary non-literal import graphsIntentional differences from Python
PackageVersionexpressions and bounded repository-local.propsimports only when the imported file stays under the active scan root.Follow-up work
Directory.Build.targetsExpected-output fixture changes
.propsimports that escape the active scan root, so out-of-scope property bags are no longer read or surfaced.propspackage versions are preserved during assembly even when local rawPackageVersionentries also existmicrosoft/regorusresolvesMicrosoft.Regorusto0.9.1in central props and consumer dependenciesdotnet/extensionsroot and nestedDirectory.Packages.propssurfaces now carry imported central package-version dependency metadata instead of empty imported-props placeholders