-
Notifications
You must be signed in to change notification settings - Fork 24
ref msysgit/git#223 give link to version history #14
Conversation
|
As requested in msysgit/git#223 by @haferburg
|
|
I meant the commit message not the comments in this pull request. BTW (for others ) you can preview the site with Pauls change here: |
|
The result looks good to me, thanks for the link @hvoigt. |
|
I am afraid that the addition of yet another link -- without addressing the feature request by @haferburg who seems to be less interested in the feature when he has to do it himself ;-) -- does clutter up the page. At least in one resolution I had a look at it, it looked wrong, too. :-( |
To clarify: the feature request was not a link to the releases. It was a request to mention the current version, and of course to keep that up-to-date. |
|
Well he had multiple questions. IMO they are all answered by looking at the releases page @paulvi added as a link. Of course we could make it nicer (but more complicated to implement) and have the current version displayed underneath the download button. That could be pulled out of the releases API by some javascript or so. But I would leave that for a future extension for someone who comes along and wants to implement that. Until then I think having a link to the history prominently on the page helps those who are interested in the latest changes. Concerning the resolution issue. It already does not look that nicely just with the 3 link we have now (at least on my phone). I think it would be better if the css could change the layout so the links are displayed underneath each other when the resolution becomes a certain degree of narrowness. Also the screenshots could be inlined into the text. The "We bring the awesome Git SCM to Windows" text, the "Download" and "Contribute" buttons could go underneath each other. I did not completely follow the discussion for the new site back then but I thought that there was such a version (at least where the buttons where underneath each other in a narrow window) in one iteration. Was that a deliberate change? @paulvi or @haferburg keen to have a look at implementing that? |
|
I just did this PR to show what is discussed in msysgit/git#223 is actually 10 minutes of work. I don't see point of discussion this minor change or possible ways how it can be improved before it is published. I personally think that would be enough. It is just html page, it is not mission critical VCS software |
|
Well I would be fine with the change. But we have not heard back from the OP if that solves the issue so I can understand @dscho's hesitation. I'll send him a ping on the issue... |
|
Or one if I forgot: If you change the commit message to contain the reasoning I'll be fine with it. |
|
I repeat
While I like msysgit, I would never look again inside. The issue could have been closed in 10 minutes, a month ago, but it is discussed by 5-10 great developers, that could do much better spending of their time. That is stupid. Or there is some unresolved communication issue, that make this project a swamp. @ALL Please find time to seat together and decide on your communication. I mute the thread. |
ref msysgit/git/issues/223