Cards moving zones during breaches give relevant info if known#8345
Merged
NoahTheDuke merged 7 commits intomtgred:masterfrom Sep 3, 2025
Merged
Cards moving zones during breaches give relevant info if known#8345NoahTheDuke merged 7 commits intomtgred:masterfrom
NoahTheDuke merged 7 commits intomtgred:masterfrom
Conversation
…p, according to rules
NBKelly
changed the title
NoahTheDuke
reviewed
Sep 2, 2025
| ;; if cards are no longer candidates, but get installed during a breach, it is known | ||
| from-zone (or (#{:discard :deck :hand} (first (get-zone card))) | ||
| (second (get-zone card))) | ||
| args (update-in args [:msg-keys :known] #(or % (contains? (set (get-in @state [:breach :known-cids from-zone] [])) (:cid card)))) |
Collaborator
There was a problem hiding this comment.
so this will set :known to a boolean?
Collaborator
There was a problem hiding this comment.
And is this duplicated logic elsewhere? Looks like you're calculating this in the new function too.
Collaborator
Author
There was a problem hiding this comment.
Sets return the matching member (or nil), so from-zone will be either :discard/:deck/:hand, or :remote[x].
But yeah, that's something I lifted 1:1 from access. Maybe it deserves a helper (or already has one that just wasn't being used).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cards that have been seen during a breach are known (unless the zone gets shuffled).
This means poetri installs can be more informative for the runner.
This also means that discards during a breach may be more informative for the runner too, ie if the card is known it goes to the discard faceup.
Closes #8339