Migrated :candidates-determined Event#8714
Merged
Merged
Conversation
NoahTheDuke
reviewed
Apr 27, 2026
| (contains? t :value)) | ||
| (:value t) | ||
| t)) | ||
| context (first targets) |
Collaborator
There was a problem hiding this comment.
yeah i think this is a holdover from me copying the target logic over
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I migrated the
:candidates-determinedevent. The:hqflag is wrapped:breached-servereven though it is not needed. Future proofing I guess.I also asked about how the event functions will change when this migration is done. I simplified the context form to make sure replacing
& targetswithcontextwill work. Turns out nothing actually uses the transformation (and if something does need to use it, go throughtargetinstead. So we just get to strip out some unneeded code.