Skip to content

Dev#116

Closed
syberkitten wants to merge 8 commits intomthenw:masterfrom
ROBOTEAM-HOME:dev
Closed

Dev#116
syberkitten wants to merge 8 commits intomthenw:masterfrom
ROBOTEAM-HOME:dev

Conversation

@syberkitten
Copy link
Copy Markdown

@syberkitten syberkitten commented Mar 12, 2018

Hey

Wanted to add a few small additions to the project I guess
most of the users might benefit:

  1. automatically stdout everything - this comes in handy.
  2. -T --title options, to give custom title name to page in case there are no files.
  3. added an "epipebomb" safety measure (method inside index.js) which eliminates "EPIPE" exception which mostly happens
    when multiple pipes are used and they are not closed. (can read about it)

I'm mostly using frontail to pipe through along with sending to browser
so it allows chaining multiple frontails, in multiple browser windows
for example (is in mobile testing) :

node dist/connect-android.js | frontail - -p 9001 -T All |  node dist/scenario.js connect | frontail - -p 9002 -T Test

The above allows opening two browsers while each having a different output from frontail
and different titles.

looking forward to your remarks and ideas :)

@philippwaller
Copy link
Copy Markdown

Great work! I am not sure if I like the "automatically stdout everything" approach. I prefer to activate features via flags. The title option is very handy! I running several docker instances and will appreciate this feature.

@mthenw
Copy link
Copy Markdown
Owner

mthenw commented Mar 16, 2018

@syberkitten thanks for contribution. Can you split those features into different PRs?

@syberkitten
Copy link
Copy Markdown
Author

Hey @mthenw, thanks I'll try do it as soon as possible -)

@syberkitten syberkitten mentioned this pull request Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants