Cleanup kotlin.compilerOptions.jvmTarget

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Kotlin JVM target configuration across Gradle build files. It streamlines the process by directly linking the Kotlin JVM target to the project's defined Java version, eliminating a previously redundant kotlinJvmTarget variable and ensuring better alignment between Java and Kotlin compilation settings.

Highlights

• Kotlin JVM Target Configuration: The kotlin.compilerOptions.jvmTarget in agency-parser/build.gradle now directly uses JvmTarget.fromTarget(rootProject.javaVersion.toString()), ensuring consistency with the project's Java version.
• Redundant Variable Removal: The kotlinJvmTarget variable has been removed from shared/build.gradle as it is no longer needed after the jvmTarget configuration update.
• Commented Code Update: A commented-out line in app-android/build.gradle was updated to reflect the new method of deriving the jvmTarget, although the line remains inactive.

Changelog

• shared-opt-dir/agency-parser/build.gradle
  • Imported org.jetbrains.kotlin.gradle.dsl.JvmTarget.
  • Configured kotlin.compilerOptions.jvmTarget to derive its value from rootProject.javaVersion.
• shared/app-android/build.gradle
  • Updated a commented-out line that previously suggested jvmTarget configuration.
• shared/build.gradle
  • Removed the kotlinJvmTarget property from the ext block.

Activity

• No specific activity (comments, reviews, or progress updates) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good cleanup, removing the hardcoded kotlinJvmTarget property and deriving the Kotlin JVM target from the javaVersion property instead. This improves consistency and maintainability across the project. The changes are logical and well-implemented. I have one suggestion to further improve the configuration by making the Kotlin toolchain explicit in the agency-parser module, which would align it with the Java toolchain configuration and practices in other modules.