Download & prepare GTFS > better error handling

[mmathieum]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces ZIP file validation checks using unzip -tqq in archive.sh and unzip_gtfs.sh, and adds the --fail flag to curl in commons.sh. The review feedback correctly identifies that using return outside of a function in these non-sourced Bash scripts will cause runtime errors, and suggests replacing them with exit 1 while also correcting copy-paste typos in the error messages.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces ZIP file integrity validation using unzip -tqq before extraction in archive.sh and unzip_gtfs.sh, and adds the --fail flag to curl under CI environments in commons.sh. The review feedback suggests improving error handling in unzip_gtfs.sh by explicitly checking for file existence first to avoid misleading error messages, and recommends applying the curl --fail flag globally rather than restricting it to CI environments to prevent silent download failures locally.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces validation checks for GTFS zip files before extraction in archive.sh and unzip_gtfs.sh, and updates commons.sh to append verbose flags in CI mode and add --fail to curl. The feedback recommends improving the zip validation by checking if the unzip -tqq exit code is greater than 1 rather than non-zero, as minor warnings can return 1. Additionally, it suggests quoting variables to prevent word splitting and removing redundant local declarations in commons.sh.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request adds validation checks for GTFS ZIP files using unzip -tqq before extraction, and updates curl options in commons.sh to fail on server errors. However, a critical bug was identified in the ZIP validation logic in both archive.sh and unzip_gtfs.sh: using [[ $? -ne 1 ]] will cause the scripts to fail on perfectly valid ZIP files (which return exit code 0). It is recommended to change these conditions to [[ $? -gt 1 ]] to correctly handle successful extractions.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request improves download and extraction scripts by configuring curl to fail on server errors, fixing CI debug logging, and adding validation checks to ensure ZIP files exist and are valid before extraction. The review feedback correctly points out that if the 'unzip' command is missing, the scripts will return exit code 127, leading to a misleading 'Invalid ZIP' error. It is recommended to explicitly handle exit code 127 to report that the 'unzip' command is not found.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[Copilot]

Pull request overview

This PR improves robustness of the GTFS download/unzip workflow by failing earlier and more explicitly when inputs are missing/invalid, reducing downstream failures during parsing/archiving.

Changes:

• Add explicit GTFS ZIP existence checks and ZIP integrity validation (unzip -tqq) before unzipping.
• Improve download failure signaling by using curl --fail (and preserving verbose output in CI).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
shared-opt-dir/agency-parser/unzip_gtfs.sh	Adds GTFS ZIP presence/integrity checks before extracting into input directories.
shared-opt-dir/agency-parser/archive.sh	Validates GTFS ZIP integrity before unzipping into archive workspace.
commons.sh	Makes download() fail on HTTP 4xx/5xx via curl --fail and keeps CI verbosity.

Comments suppressed due to low confidence (1)

shared-opt-dir/agency-parser/unzip_gtfs.sh:24

• The unzip command uses unquoted variables (${GTFS_ZIP}, ${TARGET_DIR}), which can break on whitespace/globs and is inconsistent with the quoting used later in this script. Quote both variables.

echo ">> Unzip '$GTFS_ZIP' in '$TARGET_DIR'...";
unzip -j ${GTFS_ZIP} -d ${TARGET_DIR};
checkResult $?;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.