Skip to content

Conversation

@ruor
Copy link

@ruor ruor commented May 30, 2019

No description provided.

@ruor ruor mentioned this pull request May 31, 2019
Copy link
Owner

@mtth mtth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this @ruor! Looks good, just one minor comment.

'flow': flow,
},
)
except HTTPError:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here is the same as in get_workflow_info; do you mind extracting it to a helper function (say _extract_workflow_json)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants