Skip to content

Implement custom regexp for label matching#20

Merged
muan merged 5 commits intomasterfrom
muan/regexp
Feb 4, 2014
Merged

Implement custom regexp for label matching#20
muan merged 5 commits intomasterfrom
muan/regexp

Conversation

@muan
Copy link
Owner

@muan muan commented Feb 1, 2014

I realized I don't really want to use this, so it took a while. Who knows, maybe now that it's here, I will use it. @cobyism if you're still interested in this function, it'd be awesome if you can try out this branch some time! ❤️

Fixes #2.

image

@cobyism
Copy link

cobyism commented Feb 3, 2014

Just to clarify, that regex has nothing to do with the domain option above, but instead controls the way the organisation name is matched in the label? If so, then that’s 👍. Maybe something to explain with some text like you have with the domain, but other than that 💖

@muan
Copy link
Owner Author

muan commented Feb 4, 2014

@cobyism Hahaha I completely missed that. Thank you so much! I will make changes accordingly and 🚢 this soon. :)

@muan
Copy link
Owner Author

muan commented Feb 4, 2014

image

muan added a commit that referenced this pull request Feb 4, 2014
Implement custom regexp for label matching
@muan muan merged commit 06ac00d into master Feb 4, 2014
@muan muan deleted the muan/regexp branch February 4, 2014 05:16
@cobyism
Copy link

cobyism commented Feb 4, 2014

😻 ⚡ 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot determine correct org from multiple labels

2 participants