Conversation
SPA stays on Cloudflare at iili.uk; redirects terminate on the consolidated host (rewrite → r3dr_v2). Drop the r3dr.net Caddy sites; mint base and Worker become SPA-only.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | 07088b8 | Commit Preview URL Branch Preview URL |
Aug 21 2026, 11:30 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
iili | 07088b8 | Commit Preview URL Branch Preview URL |
Aug 21 2026, 11:30 PM |
aaylward
left a comment
There was a problem hiding this comment.
Single-pass code review at xhigh effort (the Agent tool was unavailable in this context, so this is one reviewer working all angles in sequence — not the usual multi-agent fan-out with an independent verify pass). 6 findings, ranked most-severe first in the inline comments.
Headline: the method GET HEAD matcher forwards HEAD to r3dr_v2, but the smithy-cpp router (verified at the pinned 46bcd4d) does exact method-bucket dispatch and the model registers only GET — so HEAD i.iili.uk/r/{slug} answers 405 Allow: GET, not the 302 the PR's comments, READMEs, and the deleted worker test all promise. Verified against the router source; a Send("HEAD", ...) wire_test would pin it.
Also verified clean: the bare respond 404 after handle is correct under Caddy's directive order; rewrite * /r3dr/v2{path} preserves the query string; trailing-slash tolerance is re-established by the router's NormalizedTarget (so that deleted worker test's invariant survives); the {path} braces don't break the Go tests' depth counting; compose wiring (service name, TRUSTED_PROXY_CIDRS, db init) checks out; localStorage recent links self-heal to the new base.
Generated by Claude Code
Pin reverse_proxy to r3dr_v2:8091; substring-guard against r3dr.net returning on any address line; drop the orphaned www mount and caddy's depends_on r3dr. Docs say r3dr.net links died with the Caddy sites; HEAD end-to-end 302 tracked in #1433; no iili.uk/r mint window existed.
|
Folded review follow-ups in 07088b8:
|
|
Rechecked 07088b8 against the review — all six findings verified addressed. Checked out the head, re-read the diff, and ran the deploy config suite (
CI on 07088b8: everything completed is green (test-deploy, test-iili-web, format-check included); sanitizers and build-and-test still running at time of writing. Generated by Claude Code |
Short links mint as
i.iili.uk/r/{slug}now: Caddy on the consolidated box rewrites those onto r3dr_v2, and the Cloudflare Worker at iili.uk is SPA-only. Pulled the old r3dr.net / www.r3dr.net Caddy sites (Go service still in compose until chunk 3).Deploy config tests pin the new host and the gone ones; iili_web unit tests cover the mint base. After deploy, curl a known slug on i.iili.uk and mint once from the SPA to confirm.