fix(golf): restore missing Knock button during play phase#199
Merged
Conversation
The Knock button was gated on `gameState.allPlayersPeeked`, which the backend resets to false when transitioning from peeking to playing. This made the button permanently hidden. The `gamePhase === 'playing'` check already guarantees peeking is complete, so the redundant flag is removed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
muchq | c2f5f5c | Commit Preview URL Branch Preview URL |
Mar 10 2026, 08:31 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Knock button — the only way to end a Golf game — was never visible during play. The render condition depended on
allPlayersPeeked, which the backend resets tofalsewhen transitioning from the peeking phase to playing. SincegamePhase === 'playing'already guarantees peeking is complete, the redundant flag check is removed.What Changed
gameState.allPlayersPeekedfrom the Knock button render condition inGolfGame.tsxTesting Done
flowchart LR A[All players peek] -->|backend| B["allPlayersPeeked = true\ngamePhase = peeking"] B -->|countdown ends| C["allPlayersPeeked = false\ngamePhase = playing"] C -->|"before fix"| D["❌ Knock button hidden\n(allPlayersPeeked is false)"] C -->|"after fix"| E["✅ Knock button visible\n(only checks gamePhase)"] style D fill:#d9534f,color:#fff style E fill:#5cb85c,color:#fff🤖 Generated with Claude Code