feat(tracing): persist bounded trace histories - #11203
Merged
Merged
Conversation
Retain API and backend traces below the data path, restore them at initialization, and serialize clears with asynchronous consumers. Assisted-by: Codex:gpt-5
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| records := make([]T, 0, len(files)) | ||
| for _, name := range files { | ||
| data, err := os.ReadFile(filepath.Join(s.dir, name)) |
Document why persisted filenames cannot escape the trace directory and explicitly ignore the best-effort temporary-file cleanup result. Assisted-by: Codex:gpt-5 [golangci-lint]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #9308.
API and backend trace histories now persist under the configured data path and are restored across LocalAI restarts. Persistence keeps the existing independent
tracing_max_itemsbounds, advances restored numeric IDs to avoid collisions, skips corrupt records without blocking startup, and serializes clear operations with the asynchronous trace consumers so memory and disk are cleared together.Notes for Reviewers
traces/apiandtraces/backend, so this works with or without authentication and adds no database dependency.go test -count=1 ./core/trace/tracepersist ./core/trace ./core/http/middleware ./core/applicationandgo vetfor the same packages.Signed commits
Assisted-by: Codex:gpt-5