fix(fish-speech): preserve ROCm PyTorch - #11568
Merged
Merged
Conversation
The upstream editable install pins generic PyTorch packages. It replaces the HIP wheels with CUDA wheels in ROCm images. Remove those pins only for hipBLAS builds before the editable install. Keep the existing CPU and CUDA dependency behavior unchanged. Assisted-by: Codex:gpt-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #11563.
The fish-speech installer now removes upstream torch and torchaudio pins only for hipBLAS builds. The editable source install therefore keeps the ROCm wheels selected by
requirements-hipblas.txt. CPU and CUDA builds keep the existing upstream pins.The default fish-speech build target runs a lightweight regression test for ROCm, CUDA, and CPU dependency preparation.
Closes #11563
Notes for Reviewers
Focused verification:
A full backend image build was not run locally because it downloads the fish-speech model stack. Backend CI exercises the default build target.
Signed commits