fix(ollama): accept :latest tag on model lookup - #11732
Merged
Merged
Conversation
/api/tags appends :latest to untagged names, but chat and the other model endpoints looked the tagged name up as-is and 404'd. Signed-off-by: lei_lei <96427312+leilei3167@users.noreply.github.com>
localai-org-maint-bot
approved these changes
Aug 26, 2026
localai-org-maint-bot
left a comment
localai-org-maint-bot
left a comment
Collaborator
There was a problem hiding this comment.
@mudler This looks good to merge. The :latest normalization is limited to the Ollama default tag, preserves the original request model for responses, and covers both successful lookup and the unknown-model 404 path. I verified git diff --check and go test ./core/http/middleware ./core/http/endpoints/ollama -run 'TestMiddleware|TestOllamaEndpoints' -count=1. DCO passes; the normal CI matrix has not reported yet.
mudler
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/api/tags and /api/ps add
:latestto untagged names, but/api/chatand/v1/chat/completionslooked the tagged name up as-is and 404'd. Strip that default tag before config lookup so the listed name works.Fixes #11728