Skip to content

Update containers.md to fix podman image qualification - #11749

Merged
mudler merged 2 commits into
mudler:masterfrom
alex-mazzariol:patch-1
Sep 6, 2026
Merged

Update containers.md to fix podman image qualification#11749
mudler merged 2 commits into
mudler:masterfrom
alex-mazzariol:patch-1

Conversation

@alex-mazzariol

Copy link
Copy Markdown
Contributor

Description

This PR fixes no numbered issue, but just a minor documentation inconsistency with the usage of podman to run localAI.

alex-mazzariol and others added 2 commits August 27, 2026 10:24
Signed-off-by: Alex Mazzariol <alex@alex-maz.info>
Podman can reject short image names when no registry is configured. Explain why the examples use fully qualified Docker Hub names.

Assisted-by: Codex:gpt-5.6

@localai-org-maint-bot localai-org-maint-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mudler Good to merge. The Podman commands now use fully qualified Docker Hub image names, which avoids short-name resolution failures and prompts. I tightened the explanatory paragraph on the contributor branch so it does not claim that every Podman installation requires qualification. The contributor commit passes DCO, and the final diff passes git diff --check.

@localai-org-maint-bot

Copy link
Copy Markdown
Collaborator

Review pass. The change is correct and complete. One blocker.

Podman's unqualified-search-registries genuinely makes short names ambiguous or interactive, and every podman run example is now fully qualified. I checked the head revision: the two remaining unprefixed podman run lines (containers.md:232 and :258) are multi-line commands whose image argument was updated correctly. The explanatory paragraph up front is the right place for the rationale.

Blocking: DCO. Commit 54928279 ("docs(containers): clarify Podman image names") has no Signed-off-by. gh pr checks reports DCO fail. Re-signing the commit is all this needs.

Minor, and defensible: the reference tables now show docker.io/localai/localai:... under a column headed "Docker Hub", which is slightly redundant for Docker users. Reasonable since the tables serve both engines, but it is beyond "fix podman image qualification".

@mudler
mudler merged commit 4d854f9 into mudler:master Sep 6, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants