feat: add samba MCP - #32
Merged
Merged
Conversation
The server speaks SMB2/SMB3 to a share over the network instead of reading a mounted path. A cifs mount inside a container needs either a privileged container or a host bind-mount, so dialling the share directly keeps the image self-contained. It exposes six tools: list, search, read, write, move and delete. Every path is relative to the share root and passes through one cleanPath choke point, so no request can address anything outside the share. Search matches names only and never reads file contents, which keeps it cheap on a share full of large files. Reads refuse binary files and anything above SMB_READ_MAX_BYTES. Two switches restrict what the server exposes. SMB_READ_ONLY drops write, move and delete. SMB_DISABLE_DELETE drops delete, and also makes write and move refuse to overwrite an existing path, because either would destroy the previous content. The tool handlers run against a temporary directory in the specs. Four integration specs drive a real SMB server and are skipped unless SMB_TEST_ADDRESS names one; samba/README-test.md starts a disposable container for them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TCUqUeXa7TJWrifZYPzXyh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server speaks SMB2/SMB3 to a share over the network instead of reading a mounted path. A cifs mount inside a container needs either a privileged container or a host bind-mount, so dialling the share directly keeps the image self-contained.
It exposes six tools: list, search, read, write, move and delete. Every path is relative to the share root and passes through one cleanPath choke point, so no request can address anything outside the share. Search matches names only and never reads file contents, which keeps it cheap on a share full of large files. Reads refuse binary files and anything above SMB_READ_MAX_BYTES.
Two switches restrict what the server exposes. SMB_READ_ONLY drops write, move and delete. SMB_DISABLE_DELETE drops delete, and also makes write and move refuse to overwrite an existing path, because either would destroy the previous content.
The tool handlers run against a temporary directory in the specs. Four integration specs drive a real SMB server and are skipped unless SMB_TEST_ADDRESS names one; samba/README-test.md starts a disposable container for them.
Claude-Session: https://claude.ai/code/session_01TCUqUeXa7TJWrifZYPzXyh