Problem
PR #446 hosted run 31580273813 reaches native MSVC compilation after issue #459, but the CPU job fails under the preserved /WX gate because three translation units still define NOMINMAX locally after the build now defines it centrally.
Diagnostics (all C4005 promoted through C2220):
src/vllm/model_executor/models/minimax_h3_sharded.cpp:34src/vllm/platform/console_shutdown.cpp:12src/vllm/v1/kv_offload/fs_io.cpp:8
Evidence: https://github.com/mudler/vllm.cpp/actions/runs/31580273813/job/94061520820
Required outcome
Preserve the central MSVC NOMINMAX contract and strict /W4 /WX; remove or condition the redundant source-local definitions with RED/green regression evidence. Keep the correction in PR #446.
Problem
PR #446 hosted run 31580273813 reaches native MSVC compilation after issue #459, but the CPU job fails under the preserved
/WXgate because three translation units still defineNOMINMAXlocally after the build now defines it centrally.Diagnostics (all C4005 promoted through C2220):
src/vllm/model_executor/models/minimax_h3_sharded.cpp:34src/vllm/platform/console_shutdown.cpp:12src/vllm/v1/kv_offload/fs_io.cpp:8Evidence: https://github.com/mudler/vllm.cpp/actions/runs/31580273813/job/94061520820
Required outcome
Preserve the central MSVC
NOMINMAXcontract and strict/W4 /WX; remove or condition the redundant source-local definitions with RED/green regression evidence. Keep the correction in PR #446.