fix(build): guard Laguna Marlin-only helper - #25
Merged
mudler merged 2 commits intoAug 3, 2026
Conversation
Keep the Marlin environment gate out of non-Marlin translation units so AppleClang Metal builds do not fail -Werror on an unused internal helper. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [systematic-debugging] [test-driven-development]
localai-org-maint-bot
force-pushed
the
cron/fix-laguna-metal-warning
branch
from
August 3, 2026 03:05
065373d to
355fcbe
Compare
Keep the GCC 13 false-positive suppression out of Clang builds, where the unsupported warning name is fatal under the project's warning policy. Add a regression gate for the compiler boundary. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the actual AppleClang failure blocking LocalAI PR #11174.
LagunaMarlinMoeEnabled()had internal linkage but was defined outsideVT_MARLIN_NVFP4, while every consumer is compiled only inside that feature guard. Metal/non-CUDA builds therefore promoted the resulting unused-function warning to an error. This moves the helper under its owning guard and adds a static regression test.Verification:
python3 -m unittest tests.scripts.test_device_leakage.RealTreeTests.test_laguna_marlin_gate_helper_is_feature_guardedpython3 tests/scripts/test_device_leakage.py(25/25)python3 scripts/check-device-leakage.py(DSR 32, baseline unchanged)python3 scripts/check-doc-checkpoint.py --commit HEADpython3 scripts/check-agent-record.pygit diff HEAD^ --checkLocalAI Darwin CI remains the binding AppleClang build verification.