fix(build): isolate MLX headers from project warnings - #27
Merged
mudler merged 1 commit intoAug 3, 2026
Merged
Conversation
Model MLX as an imported CMake dependency with an explicit SYSTEM include interface. Keep vllm.cpp warnings fatal and remove the translation-unit diagnostic pragma. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [systematic-debugging] [test-driven-development]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PRs #23 and #24 scoped warning exceptions to
metal_mlx_provider.mm, but LocalAI Darwin job30783379823still promoted-Wgnu-folding-constantdiagnostics originating in MLX 0.29.3 headers through the target-wide-Werror. The durable ownership boundary is the CMake dependency, not one consumer translation unit.Verification
MLXDependency.cmakefailed the new regression before implementationpython3 tests/scripts/test_mlx_system_headers.py -v(structural arm passes; compiler arms skip locally because this host lacks CMake/Clang)python3 tests/scripts/test_compiler_pragma_boundaries.py -vpython3 tests/scripts/test_doc_checkpoint.py -vpython3 scripts/check-readme-structure.pypython3 scripts/check-agent-record.pypython3 scripts/check-doc-checkpoint.py --commit HEADgit diff HEAD^ --checkDarwin CI is the binding AppleClang compiler verification.