policy(POLICY-NOTHING-LANDS-DEAD): require what lands to be reached - #888
Merged
Conversation
The seam checkers ask where a capability routes. Nothing asks whether anything reaches it. Those are different failures, and only the first one is caught today. Tensor parallelism shows the cost. The audit records it at specs/tensor-parallelism-spike.md:96-101: the tp handle threaded from LayerForward down through the Qwen3-dense forward and dead-ended there. No caller above the layer passed anything but the default nullptr. No production loader passed tp into LoadMergedBf16RawNK. The only tp>1 driver in the tree was a toy test. Every declared gate was green, and no user could arrive at the feature. The rule now states that what lands is reachable from a production entry point, that the smallest failing test enters through that entry point, and that a staged slice may land unreached only when the commit names the row and issue that own the wiring. The reviewer proves it by deleting the production call site in a scratch copy and rerunning the focused gate. AGENTS.md carries only what binds, because every agent loads that file. The method, the shapes dead code takes, and the reason no checker enforces this live in the new .agents/reachability.md. No checker changes, so no gate moves. A checker that could separate a live call site from a dead one would need to resolve overloads, templates, and registration tables across the tree, and a floor coarse enough to write would pass the cases that hurt. The guide records that refusal so a later reader does not read it as an oversight. Closes #886 FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5 [Claude Code]
localai-bot
pushed a commit
that referenced
this pull request
Aug 15, 2026
… resolved BY HAND Merged at a PINNED SHA. `main` moves several times an hour here, so the branch is merged forward and re-gated rather than pushed against a moving ref. ## The keyed record was NOT taken from the automatic merge `git merge` reported `Auto-merging .agents/issue-index.md` and produced a clean tree, and that result was discarded rather than accepted. It had inserted this row's two entries BEFORE `#886`, which arrived on `main` in the same range -- an interleave, not an append, in a record whose whole contract is that it is append-only and therefore union-mergeable. Resolved the way AGENTS.md requires a keyed record to be resolved: the target branch's version was taken wholesale with `git checkout e8048ef --`, then this row's scoped edit was reapplied on top by appending the two rows at the tail. Verified, not assumed: - the two `#873` / `#874` rows are byte-identical to the ones commit 578ab36 authored; - every UNRELATED key is byte-for-byte identical to `e8048ef63` -- `diff` of the target's file against the result with only those two rows filtered out is empty, so nothing else drifted; - the target's file is a strict PREFIX of the result, which is what makes this a pure append rather than a rewrite; - no duplicate issue key exists in the merged file. ## The rest of the range Nothing incoming touches `.github/workflows/ci.yml`, `tests/scripts/test_main_baseline.py` or the four checkers this row repairs. `AGENTS.md`, `.agents/verification.md`, `.agents/workflow.md`, `.agents/porting.md` and the new `.agents/reachability.md` arrive wholesale from `main` (#888, POLICY-NOTHING-LANDS-DEAD) and are untouched here. The staged diff against `e8048ef63` is exactly the four files this row owns, and `git diff -- scripts/` is 0 lines. ## The CI failure this supersedes The previous head's `agent-record` job failed on ERROR: docs/WEIGHT-OFFLOAD.md: published but absent from website/data/nav.yaml, so it has no sidebar entry and is unreachable That is a defect that landed on `main` at 62406c3 via #885 and was fixed on `main` by #895, which is inside this range. It is not #873 and not this branch: the five #873 errors were ABSENT from that job's output, which is the CI-side proof that the repair works. Re-merging clears it. FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5 [claude-code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seam checkers ask where a capability routes. Nothing asks whether
anything reaches it. Those are different failures, and only the first
one is caught today.
What changed
AGENTS.mdgains a## Nothing lands deadsection, and.agents/gains the
reachability.mdtask guide. The rule states three things.What lands is reachable from a production entry point at its own merge
commit:
include/vllm.h, the loader,ModelRegistry::Forward, or aregistered server or command-line path on its default configuration. The
smallest failing test enters the new code through that entry point,
because a unit test that constructs the type by hand proves that the
class works and never that anything reaches it. A staged slice may land
unreached only when the commit body and the pull request body name what
is unreached, the row ID that owns the wiring, and the issue that tracks
it, and the row spec lists it under
## Owed.The fresh reviewer proves it by deleting the production call site in a
scratch copy and rerunning the focused gate. A gate that stays green
without the call site measures a class, not a capability.
AGENTS.mdcarries only what binds, because every agent loads thatfile. The method, the shapes dead code takes, and the reason no checker
enforces this live in the guide. Four existing guides gain a
cross-reference rather than a restatement:
verification.md,porting.md,porting-a-model.md, andworkflow.md.Why the change is needed
Tensor parallelism shows the cost. The audit records it at
specs/tensor-parallelism-spike.md:96-101: thetphandle threadedfrom
LayerForwarddown through the Qwen3-dense forward atqwen3.cpp:92,114,126,136and dead-ended there. No caller above thelayer passed anything but the default
nullptr. No production loaderpassed
tpintoLoadMergedBf16RawNK, and every call site omits it.The only tp>1 driver in the tree was a toy test. Every declared gate was
green, and no user could arrive at the feature.
check-fusion-consistency.py,check-runner-routing-consistency.pyandcheck-surface-coverage.pyall pass a capability that routes throughthe correct seam and that nothing calls.
How a reviewer verifies it
The change is Markdown under
.agents/andAGENTS.md. No checkerchanges, so no gate moves.
scripts/agent-preflight.sh --stagedat62406c30e: the record gatesthat govern this change are green —
check-agent-record,check-prompt-contract,check-role-discipline,check-now-current,doc-checkpoint --staged,now-current --staged.check-commit-style.pyandcheck-commit-trailers.pyoverorigin/main..HEADboth report OK.What remains unverified or out of scope
Eight preflight gates are red and none belong to this change. Seven of
them —
check-release-binary-contract,check-release-workflow,check-test-registration,test_check_release_binary_contract,test_release_manifest,test_release_pipeline,test_check_test_registration— were verified red on the clean basecommit
62406c30eitself, with this diff absent. The eighth,test_cpu_x86_llamacpp_floor, is the load-dependent floor of #618 andfailed at loadavg 104.
No checker enforces the new rule, and that is a decision rather than an
omission. A checker that could separate a live call site from a dead one
would have to resolve overloads, templates, and registration tables
across the tree, and a floor coarse enough to write would pass the cases
that hurt. The
tphandle appeared in four production files and wasstill dead. The guide records the refusal and its reason.
.agents/prompts/reviewer.mdgets noREV-REACHABILITYmethod row. Thatfile is a closed grammar pinned in
check-prompt-contract.py, so the rowwould be a semantic checker change owing its own spec and red-before
evidence. The obligation rides in the dispatched reviewer task envelope
through
workflow.mdinstead, which is weaker because an operator canomit it.
Closes #886
FOLLOWING_AGENTS_PROTOCOL
Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: AGENT:claude-opus-5 [Claude Code]