Fix Cache trait impl for SimpleCache#74
Closed
RogueMacro wants to merge 1 commit into
Closed
Conversation
Owner
|
Closing as superseded by #77, which shipped the broader v3.0.0 release work and is now merged into main. If there is any still-desired change here that did not make it into v3, please reopen or follow up with a focused PR against current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit 8e3d2a1 (updating the pdf dependency from
0.8.1to0.9.0) introduced a compilation error, because aclear(&self)function was added to thepdf::file::Cachetrait. This trait is implemented bycracker::SimpleCache.I have tested said commit and the previous, and looked at the
pdfcrate source code. It looks like the function was added in0.9.1, so the alternative would be to lock thepdfversion to0.9.0. This should be an easy fix though.Related issue: #73