[checkbox][radio][switch] Stop internal input clicks from reaching ancestors - #5176
Merged
Merged
Conversation
atomiks
added
component: checkbox
commit: |
Bundle size
PerformanceTotal duration: 1,372.30 ms -176.89 ms(-11.4%) | Renders: 78 (+0)
10 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
marked this pull request as ready for review
July 7, 2026 06:19
atomiks
requested review from
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
July 7, 2026 06:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5175
Checkbox, Switch, and Radio re-dispatch a bubbling
clickon the hidden<input>so React'sonChangefires there. That internal click also reached ancestors:stopPropagation()inonClickappeared to do nothing, and without it ancestors received two clicks per user click. Radio additionally leaked a click on arrow-key selection (input.click()inonFocus).Fix: stop the internal click's propagation at the hidden input. Ancestors now receive exactly one click, targeting the root, with standard
stopPropagation()semantics. The click still reaches the React root, soonChangekeeps firing (which rules out a non-bubbling dispatch as in Radix's fix for the same bug).