Skip to content

[checkbox] Remove redundant validation input ref - #5188

Merged
atomiks merged 2 commits into
mui:masterfrom
nami8824:checkbox-remove-validation-input-ref
Jul 9, 2026
Merged

[checkbox] Remove redundant validation input ref#5188
atomiks merged 2 commits into
mui:masterfrom
nami8824:checkbox-remove-validation-input-ref

Conversation

@nami8824

@nami8824 nami8824 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

My understanding is that validation.inputRef is redundant here.

Checkbox.Root already registers its hidden input through validation.registerInput, and validation uses the registered inputs first before falling back to validation.inputRef.

@pkg-pr-new

pkg-pr-new Bot commented Jul 8, 2026

Copy link
Copy Markdown

commit: 04b53e7

@code-infra-dashboard

code-infra-dashboard Bot commented Jul 8, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react ▼-12B(0.00%) ▼-6B(0.00%)

Details of bundle changes

Performance

Total duration: 1,327.72 ms +43.78 ms(+3.4%) | Renders: 78 (+0)

Test Duration Renders
Slider mount (300 instances) 215.81 ms 🔺+57.29 ms(+36.1%) 3 (+0)

13 tests within noise — details

Metric alarms

Test Metric Change
Slider mount (300 instances) bench:paint 🔺 +85.72 ms

Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Jul 8, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 04b53e7
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a4f3244c697e10008097084
😎 Deploy Preview https://deploy-preview-5188--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks added the component: checkbox Changes related to the checkbox component. label Jul 9, 2026

@atomiks atomiks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nami8824

@atomiks
atomiks merged commit f20bb88 into mui:master Jul 9, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: checkbox Changes related to the checkbox component.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants