[popups] Add transitionKey prop to Viewport - #5215
Open
atomiks wants to merge 30 commits into
Open
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,111.14 ms -47.59 ms(-4.1%) | Renders: 78 (+0) | Paint: 1,764.14 ms -69.23 ms(-3.8%) No significant changes — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
viewport-transition-key
branch
from
July 22, 2026 05:00
957611c to
08b0bf5
Compare
atomiks
marked this pull request as ready for review
July 22, 2026 10:38
atomiks
requested review from
aarongarciah,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
July 22, 2026 10:38
Member
|
I think this closes #1894 |
Contributor
Author
|
@flaviendelangle not quite, this just supports it if you control it externally, but it likely still needs new component parts for proper DX. It's more like an actual workaround now though. |
atomiks
force-pushed
the
viewport-transition-key
branch
from
July 22, 2026 11:30
b87eb30 to
ee9a96f
Compare
Member
|
Could be worth answering on the issue once we merge this one to let people know their is a workaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viewportpreviously only animated content changes caused by switching detached triggers. This addstransitionKeyfor content that changes in place while a popup stays open.Changes
transitionKeytoPopover.Viewport,Menu.Viewport,Tooltip.Viewport, andPreviewCard.Viewport.data-activation-directionand handled multi-level returns.Demos
Popover, Menu, Tooltip, Preview Card