[number field] Expand test coverage#5280
Merged
atomiks merged 3 commits intoJul 20, 2026
Merged
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,283.32 ms -137.51 ms(-9.7%) | Renders: 78 (+0) | Paint: 2,025.83 ms -193.07 ms(-8.7%)
12 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
claude/number-field-full-coverage-cf36d3
branch
from
July 20, 2026 04:57
81181f2 to
614d807
Compare
atomiks
force-pushed
the
claude/number-field-full-coverage-cf36d3
branch
from
July 20, 2026 10:56
9794890 to
23bc764
Compare
atomiks
marked this pull request as ready for review
July 20, 2026 10:56
atomiks
requested review from
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
July 20, 2026 10:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands Number Field test coverage to 100% across statements, branches, functions, and lines on merged jsdom and Chromium results, and removes the dead code the sweep uncovered.
Changes
isScrubbingRefguard on pointer move. Effects can tear down and re-run without unmounting under<Activity>, which clears the ref whileisScrubbingstays true and re-attaches the listener, so a bare mouse move changed the value.getNumberLocaleDetailsalways return a decimal separator, which drops the optional-decimal branches inparseNumberandNumberField.Root.willSetHome/willSetEndpair inNumberField.Inputwith a single boundary value, removing an unreachable?? null.setValuealways records the stored value before those run, so the fallback could never fire.parseNumber, the redundant cursor null check inNumberField.ScrubArea, and the unusedSCROLLING_POINTER_MOVE_DISTANCEconstant.