[test] Add Guidepup screen reader tests#5328
Draft
aarongarciah wants to merge 1 commit into
Draft
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,223.17 ms -82.47 ms(-6.3%) | Renders: 78 (+0) | Paint: 1,910.36 ms -130.18 ms(-6.4%)
12 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aarongarciah
commented
Jul 24, 2026
Comment on lines
+25
to
+28
| # Exact versions intentionally updated before the 72-hour release-age window elapsed. | ||
| - '@guidepup/guidepup@0.29.2' | ||
| - '@guidepup/playwright@0.18.0' | ||
| - '@guidepup/setup@0.24.1' |
Member
Author
There was a problem hiding this comment.
This would be removed before merging.
aarongarciah
commented
Jul 24, 2026
| @@ -0,0 +1,38 @@ | |||
| import { expect } from '@playwright/test'; | |||
| import { screenReaderTest as test, type ScreenReaderPlaywright } from '@guidepup/playwright'; | |||
Member
Author
There was a problem hiding this comment.
screenReaderTest automatically uses VoiceOver or NVDA depending on the OS.
aarongarciah
commented
Jul 24, 2026
|
|
||
| const MAX_NAVIGATION_STEPS = 10; | ||
|
|
||
| async function navigateToItem( |
Member
Author
There was a problem hiding this comment.
This helper should be extracted as we see fit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a minimal Guidepup screen-reader test using the existing Radio fixture, with local VoiceOver support and Windows/NVDA CI coverage. No VoiceOver CI coverage for now.
CI run: https://github.com/mui/base-ui/actions/runs/30082080229/job/89445735040?pr=5328