Skip to content

[combobox][select] Inherit root disabled state in items - #5365

Merged
atomiks merged 3 commits into
mui:masterfrom
chuganzy:combobox-disabled
Jul 30, 2026
Merged

[combobox][select] Inherit root disabled state in items#5365
atomiks merged 3 commits into
mui:masterfrom
chuganzy:combobox-disabled

Conversation

@chuganzy

Copy link
Copy Markdown
Contributor

This PR fixes Combobox.Item and Select.Item not inheriting the disabled state from their root components.

Related discussion

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown

commit: ff77813

@code-infra-dashboard

code-infra-dashboard Bot commented Jul 29, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 🔺+32B(+0.01%) 🔺+21B(+0.01%)

Details of bundle changes

Performance

Total duration: 1,259.84 ms -17.45 ms(-1.4%) | Renders: 78 (+0) | Paint: 1,988.53 ms -24.48 ms(-1.2%)

Test Duration Renders
Combobox open — 500 items 45.48 ms +7.17 ms(+18.7%) 4 (+0)

14 tests within noise — details

Metric alarms

Test Metric Change
Combobox open — 500 items bench:paint#combobox-open 🔺 +14.31 ms
Combobox open — 500 items bench:paint 🔺 +14.31 ms

Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Jul 29, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit ff77813
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a6a9de378793b0008aca375
😎 Deploy Preview https://deploy-preview-5365--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@mnajdova mnajdova added component: select Changes related to the select component. type: bug It doesn't behave as expected. component: combobox Changes related to the combobox component. labels Jul 29, 2026
@atomiks
atomiks merged commit 60ba458 into mui:master Jul 30, 2026
23 checks passed
@chuganzy
chuganzy deleted the combobox-disabled branch July 30, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: combobox Changes related to the combobox component. component: select Changes related to the select component. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants