[number field] Stop incrementing when disabled during press-and-hold - #5435
Open
alex-js-ltd wants to merge 3 commits into
Open
[number field] Stop incrementing when disabled during press-and-hold#5435alex-js-ltd wants to merge 3 commits into
alex-js-ltd wants to merge 3 commits into
Conversation
alex-js-ltd
marked this pull request as ready for review
August 8, 2026 14:38
alex-js-ltd
requested review from
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
August 8, 2026 14:38
commit: |
Bundle size
PerformanceTotal duration: 1,318.78 ms +104.13 ms(+8.6%) | Renders: 76 (+0) | Paint: 2,056.11 ms +124.46 ms(+6.4%)
14 tests within noise — details Metric alarms
Check out the code infra dashboard for more information about this PR. |
alex-js-ltd
changed the title
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Stops an active Number Field press-and-hold interaction when the field becomes disabled.
usePressAndHoldnow observes its effectivedisabledstate and callsstopAutoChange()when it becomestrue. This clears the pending timeout and repeating interval while preserving the existing pointer-release handling.Test
Added a regression test that starts holding the increment button, disables the Number Field, waits beyond the repeat delay, and verifies that the value remains
1. Before the fix, the pending hold timer performed another increment and changed the value to2.pnpm test:jsdom NumberField --no-watchpnpm test:chromium NumberField --no-watchFixes #5434