[toast] Support partial data updates - #5464
Merged
Merged
Conversation
chuganzy
marked this pull request as ready for review
August 11, 2026 06:16
chuganzy
requested review from
aarongarciah,
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
August 11, 2026 06:16
commit: |
Bundle size
PerformanceTotal duration: 1,129.08 ms -158.17 ms(-12.3%) | Renders: 76 (+0) | Paint: 1,783.68 ms -252.05 ms(-12.4%)
11 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes shallow-merging custom toast data when updating a toast.
Currently, the
datapassed toupdatereplaces the existing data, so fields that should remain unchanged must be passed again:With this change, the same update can be written as:
The existing
uploadIdis preserved, anddatais typed asPartial<Data>, consistent with the other update options.