Skip to content

[popups] Fix disabled anchor tracking on scroll - #5478

Merged
atomiks merged 2 commits into
mui:masterfrom
atomiks:codex/popover-disable-anchor-scroll-tracking
Aug 17, 2026
Merged

[popups] Fix disabled anchor tracking on scroll#5478
atomiks merged 2 commits into
mui:masterfrom
atomiks:codex/popover-disable-anchor-scroll-tracking

Conversation

@atomiks

@atomiks atomiks commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #5405

disableAnchorTracking still subscribed to overflow-ancestor scroll events, so popups followed their anchor during scrolling even though element resize and layout-shift tracking were disabled. The ancestorScroll option was dropped in #1249 during an unrelated refactor.

This restores the original behavior while leaving ancestorResize enabled for resize updates.

Changes

  • Disable overflow-ancestor scroll updates when anchor tracking is disabled.
  • Add Chromium regression coverage that scrolls an overflow ancestor and verifies the popup remains in its initial position.

@atomiks atomiks added component: popover Changes related to the popover component. type: regression A bug, but worse, it used to behave as expected. labels Aug 13, 2026 — with ChatGPT Codex Connector
@pkg-pr-new

pkg-pr-new Bot commented Aug 13, 2026

Copy link
Copy Markdown

commit: 7a04b35

@code-infra-dashboard

code-infra-dashboard Bot commented Aug 13, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 🔺+18B(0.00%) 🔺+10B(+0.01%)

Details of bundle changes

Performance

Total duration: 1,382.89 ms +3.01 ms(+0.2%) | Renders: 76 (+0) | Paint: 2,157.69 ms +30.13 ms(+1.4%)

Test Duration Renders
Menu mount (300 instances) 124.29 ms 🔺+24.40 ms(+24.4%) 1 (+0)

14 tests within noise — details

Metric alarms

Test Metric Change
Menu mount (300 instances) bench:paint 🔺 +35.04 ms

Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Aug 13, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 7a04b35
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a82b1ffa816d00008678147
😎 Deploy Preview https://deploy-preview-5478--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks
atomiks marked this pull request as ready for review August 13, 2026 11:05
@atomiks atomiks added scope: all components Widespread work has an impact on almost all components. and removed component: popover Changes related to the popover component. labels Aug 17, 2026
@atomiks
atomiks merged commit 943caad into mui:master Aug 17, 2026
25 checks passed
@atomiks
atomiks deleted the codex/popover-disable-anchor-scroll-tracking branch August 17, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: all components Widespread work has an impact on almost all components. type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[popover] Scroll position is still tracked with disableAnchorTracking

1 participant