[field][checkbox][switch] Fix controlled blur validation and stale filled state - #5563
Merged
Merged
Conversation
atomiks
added
component: switch
commit: |
Bundle size
PerformanceTotal duration: 1,103.23 ms -27.01 ms(-2.4%) | Renders: 76 (+0) | Paint: 1,790.28 ms -55.89 ms(-3.0%)
14 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
fix/field-blur-filled-state
branch
from
August 25, 2026 07:41
7348abe to
2999b2c
Compare
atomiks
marked this pull request as ready for review
August 25, 2026 08:47
atomiks
requested review from
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
August 25, 2026 08:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two field lifecycle fixes. The blur half is a regression from #5460; the filled half predates it.
validationMode="onBlur", a blur handler that normalizes the controlled value (e.g..trim()) had its commit retired by the value's prop transition. The blur handler now re-commits the settled DOM value in a microtask, unless it settled back to the initial value (a programmatic reset stays quiet). Async normalization after blur is still not covered.filledis now derived from the current value in a layout effect (theNumberFieldpattern) instead of transition callbacks and write-only mount effects. This fixes staledata-filledon remounts and customrenderelements inField.Control,Checkbox.Root, andSwitch.Root, andCheckboxGroupnow fully owns the filled state.dirtystays transition-driven: deriving it needs mount-timeinitialValueordering guarantees and interacts with #5345.