[floating-ui] Preserve pointer modality for untyped clicks - #5634
Open
brijeshb42 wants to merge 1 commit into
Open
[floating-ui] Preserve pointer modality for untyped clicks#5634brijeshb42 wants to merge 1 commit into
brijeshb42 wants to merge 1 commit into
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,300.40 ms -45.28 ms(-3.4%) | Renders: 76 (+0) | Paint: 2,087.53 ms -83.04 ms(-3.8%) No significant changes — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
brijeshb42
marked this pull request as ready for review
September 4, 2026 05:48
brijeshb42
requested review from
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
September 4, 2026 05:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pointer click can legitimately have an empty pointerType. Preserve the preceding pointer interaction in that case instead of classifying the close as keyboard-driven.
#5630 provides the dependency-level reproduction: resolving @testing-library/user-event 14.6.6 causes the Dialog and Popover finalFocus tests to fail without this change.
Includes a focused regression test that dispatches an empty-pointerType click after a mouse pointerdown.