[Backdrop] Adds audio feedback for backdrop state change for assistive tech - #37202
Closed
michellexliu wants to merge 2 commits into
Closed
[Backdrop] Adds audio feedback for backdrop state change for assistive tech#37202michellexliu wants to merge 2 commits into
michellexliu wants to merge 2 commits into
Conversation
Netlify deploy previewhttps://deploy-preview-37202--material-ui.netlify.app/ @material-ui/core: parsed: +0.09% , gzip: +0.12% Bundle size report |
mj12albert
reviewed
May 11, 2023
| ownerState={{ ...ownerState, ...rootSlotProps?.ownerState }} | ||
| classes={classes} | ||
| ref={ref} | ||
| ref={ref || backdropRef} |
Member
There was a problem hiding this comment.
@michellexliu Thanks for working on this!
There is a useForkRef utility for handling the ref in these cases:
import useForkRef from '../utils/useForkRef';
const Backdrop = React.forwardRef(function Backdrop(inProps, ref) {
const backdropRef = React.useRef(null);
const handleRef = useForkRef(backdropRef, ref);
return (
<TransitionComponent {/* etc */}>
<BackdropRoot ref={handleRef}>
{/* ... */}
</BackdropRoot>
</TransitionComponent>
)
})(An example https://github.com/mui/material-ui/blob/master/packages/mui-material/src/Chip/Chip.js#L347-L348)
ZeeshanTamboli
left a comment
Member
There was a problem hiding this comment.
I checked on NVDA version 2023.1 and I am not getting any announcements in https://deploy-preview-37202--material-ui.netlify.app/material-ui/react-backdrop/#example. Or am I missing something here?
Member
|
Since there is no reply and updates from the author, I am closing it. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #31371
aria-liveattributesbackdrop-demo.mov