Merged
Conversation
victorb
reviewed
May 1, 2018
| "name": "multiaddr", | ||
| "version": "5.0.0", | ||
| "description": "multiaddr implementation (binary + string representation of network addresses)", | ||
| "lead-maintainer": "Victor Bjelkholm <victorbjelkholm@gmail.com>", |
Member
There was a problem hiding this comment.
shouldn't this be leadMaintainer to follow the rest of the casing of keys in package.json?
Member
Author
There was a problem hiding this comment.
Good point. Now I've to change it all xD
vmx
reviewed
May 2, 2018
| "coverage-publish": "aegir coverage publish", | ||
| "docs": "aegir docs" | ||
| }, | ||
| "pre-commit": [ |
Member
There was a problem hiding this comment.
This should not be removed, but changed to pre-push. I'd also like to see a better commit message :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ipfs/community#301