Open confirmed links and paths in a floating side panel beside the terminal - #61
Merged
Conversation
…rminal Closes #58. iPad: a card over the pane (leading-seam resize, admitted at a 660-pt pane, a Stage Manager shrink moves it into a tab). Vision Pro: a slab hanging off the glass from a third trailing ornament — one static strip twice the window's width, glass-relative geometry, a handle on each edge, the card frozen into a blurred bitmap while it moves. ✕ · ↗ TAB lead the row and the viewer's controls expand by measured priority. One panel per terminal tab, carried through merge/split, width remembered per device; iPhone unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #58. A confirmed path or web link now opens in a floating side panel beside the live terminal — a shadowed card over the pane on iPad, a slab hanging off the glass's trailing edge on Vision Pro — instead of as a tab. The terminal is never re-laid out.
↗ TABmoves the same live viewer into a tab; a second summon replaces the first (one panel per terminal tab); the panel closes with its tab and rides along through merge/split; its width is remembered per device. iPhone is unchanged.Summary
TerminalWorkspace.sidePanelskeyed by the HOST terminal tab id (survives merge/split);SidePanelViewControllerwraps the existingViewportPaneViewController/FileViewerPaneViewControllerwith one 30-pt action row;AuxiliaryPaneController.routeModelets↗ TABre-register the live controller as an auxiliary tab without a downcast..trailingUIHostingOrnamenthosting ONE static mount — a transparent strip twice the window's width, centred on the glass edge — so a drag never changes the ornament. The card's geometry is stored glass-relative (width,overhang= right edge past the glass, default 440, max 800); both handles have two-way travel from the default and the left handle can pull the card across the terminal down to a 320-pt reserve. Drags freeze the card into one blurred bitmap until release (per-tick reflow and per-tick system-glass resizes were both unusable on device); under GLASS the platter steps out for the drag.✕ · ↗ TABlead, then the viewer's identity and controls, which EXPAND as the width allows by measured priority (▤ TREE · REFRESH · SOURCE|DIFF · SELECT · A− A+ · host; ⌗ SYSTEM);⋯only for what did not fit. Header on iPad, bottom bar on visionOS.SidePanel.swift): admission policy, clamps, strip/overlay geometry and the drag arithmetic, all unit-tested without UIKit.SidePanelWidthStorepersists per platform.debug.sidepanelsplit|sidepanelclose|sidepanelwidth;MULTIPLEX_SIDE_PANEL=0forces the legacy tab road. 18 new localized keys (zh-Hant, ja); the catalog also gains the 22 iPad-only keys an IDE build had left untranslated.links-and-viewers.md,input-and-windows.md,architecture.md,e2e-headless.md,i18n.md; DESIGN.md, README, TestFlight line.Proof
Ten feedback rounds on Vision Pro hardware drove the handle design (reach, two-way travel, performance, row placement, control order). Headless E2E on both simulators from a fresh install: ⌗ panel → width hook → ▤ replaces ⌗ → ✕ → ▤ → ↗ TAB → relaunch restores nothing; the visionOS card's default edges measured at the terminal's edge / 440 pt past the glass, the width hook moving only the left edge.
./Tools/build.sh lintclean · visionOS 1328 XCTests green · iPad 1334 green ·ruby Tools/check-metadata.rbOK.Checklist
./Tools/build.sh lintpassesMultiplexTests)fastlane/testflight-whats-new.txt