Add onElementWaterInteract event

[Unde-R]

Why we need It?

Well looks like we have onVehicleExplode and many other vehicle events but we don't have this one, also as requested in issue #1426, this PR introduces a new event in MTA since not everyone can use cols etc... and It's better than adding a timer or calling onClientRender or something to check if the element isInWater.
(Also this event is triggered for unoccupied vehicles too)

Functionality

 function teteVehicle(thep)
 local x, y, z = getElementPosition(thep)
 teteCar = createVehicle(411, x+2, y, z)
 addEventHandler("onVehicleDrown", teteCar, function()
 outputChatBox("rip Tete car")
 end)
 end
 addCommandHandler("tetecar", teteVehicle)

This event is triggered when a vehicle drowns.

Screenshots

[TheNormalnij]

I think that this event need to be complex. I see this like a onElementWaterInteract what will works with peds, vehicles and objects (maybe) and has bWaterInOrOut parameter.

[Unde-R]

for objects not worth it.
We'll need to get a proper event name

[Unde-R]

@qaisjp any ideas?

[Pirulax]

This is a convention in the code more or less, afaik.
But I'd use {} there, or CLuaArguments() (but {} should work)
Not even sure why CallEvent doesn't default construct CLuaArguments

[Pirulax]

Same here

[qaisjp]

I think that this event need to be complex. I see this like a onElementWaterInteract what will works with peds, vehicles and objects (maybe) and has bWaterInOrOut parameter.

I agree with @TheNormalnij's comment (copied above, from here: #1657 (comment))

This onVehicleDrown event doesn't look like it's detecting when a vehicle drowns, but when it interacts with water. Changing the event name now would make this a matter of finding a reason to merge code that accidentally doesn't work as intended.

Please create an issue proposing what feature you want to implement. In that issue, once we've discussed the what the feature should look like, we can discuss whether the code here is appropriate for that. In your issue, please try and provide answers to the questions written here. (Yes, it's a link to Windows Calculator's repo. See #887 for more context on what a "proposal" means.)

[Unde-R]

I think that this event need to be complex. I see this like a onElementWaterInteract what will works with peds, vehicles and objects (maybe) and has bWaterInOrOut parameter.

I agree with @TheNormalnij's comment (copied above, from here: #1657 (comment))

This onVehicleDrown event doesn't look like it's detecting when a vehicle drowns, but when it interacts with water. Changing the event name now would make this a matter of finding a reason to merge code that accidentally doesn't work as intended.

Please create an issue proposing what feature you want to implement. In that issue, once we've discussed the what the feature should look like, we can discuss whether the code here is appropriate for that. In your issue, please try and provide answers to the questions written here. (Yes, it's a link to Windows Calculator's repo. See #887 for more context on what a "proposal" means.)

sure even if #1426 exists?

[TheNormalnij]

GTA SA store IN_WATER state in physical flags. You can add onClientElementPhysicalStateChanged ( oldState, newState ) for peds/vehicles/obejct. oldState - physical flags before GTA call ProcessControl, newState - after ProcessControl. You can find ProcessControl hooks in multiplayer_keysync.cpp

[TheNormalnij]

If you want to add serverside event, you don't need save last isWater state.

if (flags.data.bIsInWater != pVehicle->IsInWater())
{
    ...
}

Correct me if it's wrong

[Unde-R]

If you want to add serverside event, you don't need save last isWater state.

if (flags.data.bIsInWater != pVehicle->IsInWater())
{
    ...
}

Correct me if it's wrong

cheers gonna try I've seen flag code somewhere I'll try it

[TheNormalnij]

[github-actions]

This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically.

[github-actions]

This draft pull request was closed because it has been marked stale for 30 days with no activity.