Fix server-side debugscript behavior #3499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally refactor loop.
botder
reviewed
Jun 20, 2024
TracerDS
suggested changes
Jun 21, 2024
Contributor
|
Nice |
botder
reviewed
Jun 21, 2024
FileEX
requested changes
Jun 22, 2024
botder
reviewed
Jun 23, 2024
Thanks for help @FileEX Co-Authored-By: FileEX <alkom@t.pl>
TracerDS
suggested changes
Jun 24, 2024
Contributor
|
|
botder
requested changes
Jun 26, 2024
Member
botder
left a comment
botder
left a comment
There was a problem hiding this comment.
You really don't need the enumerations in the header file. You don't use them there.
botder
approved these changes
Jun 26, 2024
Member
botder
left a comment
botder
left a comment
There was a problem hiding this comment.
I am not going to nag any further, but you should know that CScriptDebugging::CheckForSufficientDebugLevel could be static (can also be a simple free-standing function in the .cpp file) because you don't access/modify any class member in the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #3498 due the fact the client isn't aware of debugscript level. Thanks for @TracerDS (refactored for loop) & @MegadreamsBE (help with getting rid of magic numbers).