Fix outputDebugString level 4 not being logged #3553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3552
Essentially a client-side port of #3499 by moving the enum and CheckForSufficientDebugLevel into a shared class. Using this check makes level 4 equal to level 0 for the purposes of the level sufficiency check which allows its contents to be written to clientscript.log as intended.
At this moment the level check doesn't serve much of a purpose (as it's always set to 3 client-side, through setLogFile) but it does pave the way to someday only log down items based on the debugscript client-side if desired. Either way it's a cleaner solution than adding a secondary check for level 4.