Fix bullet synchronization by using total ammo instead of ammo in clip

[shadylua]

In the original code,
if (pPlayer->GetWeaponAmmoInClip(static_cast<unsigned char>(m_weapon)) == 0)

was checking the weapon’s clip ammo, but it always returned 0. Because of that, the function would return false and the event couldn’t communicate properly with the function it was supposed to trigger.

After changing it to check the total ammo instead, the issue was resolved.

and below you can see the results in the video clip :

axmal4.mp4

[PerikiyoXD]

What happens if you empty the clip? Will it trigger damage?

[ArranTuna]

As this fixes a commit by Dutchman I've requested his review.

[shadylua]

It has been merged, but I think we need to refresh the code again. I just tested it and the serverside doesn't trigger onPlayerWeaponFire.

need :

#include "CWeaponNames.h"

// Check if weapon has ammo
const auto type = static_caststd::uint8_t(m_weapon);
const auto slot = CWeaponNames::GetSlotFromWeapon(type);
if (pPlayer->GetWeaponTotalAmmo(slot) <= 0)
return false;

[Dutchman101]

@shadylua Please open a new PR for that