Fix testSphereAgainstWorld returning nil hitElement for buildings - #5140
Merged
FileEX merged 1 commit intoAug 2, 2026
Merged
Conversation
…gainstWorld Add buildings pool lookup to CPoolsSA::GetEntity; set stored pointer on building creation so entity resolves back to its client element.
Member
|
|
FileEX
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
hitElementreturning nil whentestSphereAgainstWorld(andprocessLineOfSight) hits a building created withcreateBuilding.Motivation
Resolves #5136.
CPoolsSA::GetEntitynever checked the buildings pool, soCEntity*resolution for a building always fell through to null. Even after that,testSphereAgainstWorldstill returned nil because it resolves its element throughGetStoredPointer, whichCClientBuilding::Createnever set on the native entity, unlike objects, peds and vehicles.Test plan
Created a building with
createBuilding, calledtestSphereAgainstWorldandprocessLineOfSightagainst it. Before the fix, both returned a hit with a nilhitElement; after the fix,hitElementcorrectly resolves to the building.Checklist