Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC/Sirius patch 2 #5816

Merged
merged 70 commits into from Feb 2, 2024
Merged

RC/Sirius patch 2 #5816

merged 70 commits into from Feb 2, 2024

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Jan 8, 2024

Reasoning behind the pull request

  • Sirius patch 2

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (06f147d) 80.14% compared to head (b3f8514) 80.15%.

Files Patch % Lines
consensus/spos/bls/subroundEndRound.go 75.00% 2 Missing and 1 partial ⚠️
factory/processing/processComponents.go 60.00% 1 Missing and 1 partial ⚠️
factory/processing/processComponentsHandler.go 75.00% 1 Missing and 1 partial ⚠️
process/block/baseProcess.go 84.61% 1 Missing and 1 partial ⚠️
process/block/metablock.go 50.00% 1 Missing and 1 partial ⚠️
state/trackableDataTrie/trackableDataTrie.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5816      +/-   ##
==========================================
+ Coverage   80.14%   80.15%   +0.01%     
==========================================
  Files         708      709       +1     
  Lines       94043    94135      +92     
==========================================
+ Hits        75373    75458      +85     
- Misses      13326    13330       +4     
- Partials     5344     5347       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iulianpascalau and others added 21 commits January 9, 2024 11:32
…23.01.05

Non critical fixes for Sirius (patch 2)
- added a new metric that contains the reason of step-in, in case the node is not main node and the main node failed
@iulianpascalau iulianpascalau marked this pull request as ready for review February 2, 2024 10:43
@sstanculeanu sstanculeanu merged commit d5bb384 into master Feb 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants