-
Notifications
You must be signed in to change notification settings - Fork 45
Add and remove missing roles for sfts #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/tokenManagement/resources.ts
Outdated
| removeRoleNFTUpdate: boolean; | ||
| removeRoleESDTModifyRoyalties: boolean; | ||
| removeRoleESDTSetNewUri: boolean; | ||
| removeRoleESDTModifyCreator: boolean; | ||
| removeRoleNFTRecreate: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be optional.
| options.removeRoleNFTBurn ? args.push(new StringValue("ESDTRoleNFTBurn")) : 0; | ||
| options.removeRoleNFTAddQuantity ? args.push(new StringValue("ESDTRoleNFTAddQuantity")) : 0; | ||
| options.removeRoleESDTTransferRole ? args.push(new StringValue("ESDTTransferRole")) : 0; | ||
| options.removeRoleESDTTransferRole ? args.push(new StringValue("ESDTTransferRole")) : 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 🚀
No description provided.