Skip to content

Add and remove missing roles for sfts #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025
Merged

Add and remove missing roles for sfts #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
843936a
Add and remove missing roles on sfts
danielailie Jun 3, 2025
6b6e293
Bump Version
danielailie Jun 3, 2025
27f66cd
Make this roles optional
danielailie Jun 3, 2025
adb2b0b
Remove duplicated role
danielailie Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@multiversx/sdk-core",
"version": "14.1.1",
"version": "14.1.2",
"description": "MultiversX SDK for JavaScript and TypeScript",
"author": "MultiversX",
"homepage": "https://multiversx.com",
Expand Down
10 changes: 10 additions & 0 deletions src/tokenManagement/resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ export type SemiFungibleSpecialRoleInput = {
addRoleNFTBurn: boolean;
addRoleNFTAddQuantity: boolean;
addRoleESDTTransferRole: boolean;
addRoleNFTUpdate?: boolean;
addRoleESDTModifyRoyalties?: boolean;
addRoleESDTSetNewUri?: boolean;
addRoleESDTModifyCreator?: boolean;
addRoleNFTRecreate?: boolean;
};

export type SpecialRoleInput = {
Expand Down Expand Up @@ -61,6 +66,11 @@ export type UnsetSemiFungibleSpecialRoleInput = {
removeRoleNFTBurn: boolean;
removeRoleNFTAddQuantity: boolean;
removeRoleESDTTransferRole: boolean;
removeRoleNFTUpdate?: boolean;
removeRoleESDTModifyRoyalties?: boolean;
removeRoleESDTSetNewUri?: boolean;
removeRoleESDTModifyCreator?: boolean;
removeRoleNFTRecreate?: boolean;
};

export type UnsetSpecialRoleInput = {
Expand Down
10 changes: 10 additions & 0 deletions src/tokenManagement/tokenManagementTransactionsFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,11 @@ export class TokenManagementTransactionsFactory {
options.addRoleNFTBurn ? args.push(new StringValue("ESDTRoleNFTBurn")) : 0;
options.addRoleNFTAddQuantity ? args.push(new StringValue("ESDTRoleNFTAddQuantity")) : 0;
options.addRoleESDTTransferRole ? args.push(new StringValue("ESDTTransferRole")) : 0;
options.addRoleNFTUpdate ? args.push(new StringValue("ESDTRoleNFTUpdate")) : 0;
options.addRoleESDTModifyRoyalties ? args.push(new StringValue("ESDTRoleModifyRoyalties")) : 0;
options.addRoleESDTSetNewUri ? args.push(new StringValue("ESDTRoleSetNewURI")) : 0;
options.addRoleESDTModifyCreator ? args.push(new StringValue("ESDTRoleModifyCreator")) : 0;
options.addRoleNFTRecreate ? args.push(new StringValue("ESDTRoleNFTRecreate")) : 0;

const dataParts = ["setSpecialRole", ...this.argSerializer.valuesToStrings(args)];

Expand All @@ -336,6 +341,11 @@ export class TokenManagementTransactionsFactory {
options.removeRoleNFTBurn ? args.push(new StringValue("ESDTRoleNFTBurn")) : 0;
options.removeRoleNFTAddQuantity ? args.push(new StringValue("ESDTRoleNFTAddQuantity")) : 0;
options.removeRoleESDTTransferRole ? args.push(new StringValue("ESDTTransferRole")) : 0;
options.removeRoleNFTUpdate ? args.push(new StringValue("ESDTRoleNFTUpdate")) : 0;
options.removeRoleESDTModifyRoyalties ? args.push(new StringValue("ESDTRoleModifyRoyalties")) : 0;
options.removeRoleESDTSetNewUri ? args.push(new StringValue("ESDTRoleSetNewURI")) : 0;
options.removeRoleESDTModifyCreator ? args.push(new StringValue("ESDTRoleModifyCreator")) : 0;
options.removeRoleNFTRecreate ? args.push(new StringValue("ESDTRoleNFTRecreate")) : 0;

const dataParts = ["unSetSpecialRole", ...this.argSerializer.valuesToStrings(args)];

Expand Down
Loading