Skip to content

Comments

FIX(client): Update chat bar if selected channel target state is modified#6748

Merged
Hartmnt merged 2 commits intomumble-voip:masterfrom
Hartmnt:fix_chat_dsync_channel
Apr 6, 2025
Merged

FIX(client): Update chat bar if selected channel target state is modified#6748
Hartmnt merged 2 commits intomumble-voip:masterfrom
Hartmnt:fix_chat_dsync_channel

Conversation

@Hartmnt
Copy link
Member

@Hartmnt Hartmnt commented Mar 7, 2025

FIX(client): Update chat bar if selected channel target state is modified

Previously, the chat bar would not update its text when a selected target
channel was modified.

This commit adds a signal slot to the channel state modified message
and updates the chat bar accordingly.

Fixes #1884

REFAC(client): Move forced visual update from Messages.cpp to channelState slot

Hartmnt added 2 commits March 7, 2025 18:28
…fied

Previously, the chat bar would not update its text when a selected target
channel was modified.

This commit adds a signal slot to the channel state modified message
and updates the chat bar accordingly.

Fixes mumble-voip#1884
@Hartmnt Hartmnt added client ui bug A bug (error) in the software auto-backport-to-1.5.x labels Mar 7, 2025
@Hartmnt Hartmnt merged commit 177055f into mumble-voip:master Apr 6, 2025
23 checks passed
@Krzmbrzl
Copy link
Member

Krzmbrzl commented Apr 6, 2025

💔 All backports failed

Status Branch Result
1.5.x Backport failed because of merge conflicts

You might need to backport the following PRs to 1.5.x:
- FIX(client): Don't assume SSL error == SSL version mismatch
- FEAT(client): Add "Move To Own Channel" action to user context menu
- FIX(ui): Update menu items to comform to design standards

Manual backport

To create the backport manually run:

backport --pr 6748

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat bar text desync

2 participants