feature: adds experimental ios support#421
Merged
Merged
Conversation
baszalmstra
changed the title
baszalmstra
commented
Jul 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 83.81% 83.04% -0.77%
==========================================
Files 273 280 +7
Lines 16179 16520 +341
==========================================
+ Hits 13560 13719 +159
- Misses 2619 2801 +182
Continue to review full report at Codecov.
|
Wodann
requested changes
Jul 7, 2022
Collaborator
Wodann
left a comment
Wodann
left a comment
There was a problem hiding this comment.
Some small comments. Otherwise LGTM :)
Wodann
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds experimental targets to run Mun on iOS. It adds the targets:
x86_64-apple-iosaarch64-apple-iosaarch64-apple-ios-simThese are not officially supported since we don't test them in CI.
I also had to do some modifications in the linker to make sure iOS and iOS-sim are properly targeted.
We can add lot more features to add proper support like lipo and stuff but at least this enables you to try Mun on iDevices!
NOTE: I have not tested this on an actual iDevice so I don't know if this actually works on the real hardware.
NOTE: As mentioned in #417 (comment) I don't think this will pass App Store rules because loading of dynamic libraries at runtime is not permitted.
Closes #417