Skip to content

Conversation

@denialhaag
Copy link
Member

@denialhaag denialhaag commented Dec 4, 2025

Description

This PR updates the setup-mlir version.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Dec 4, 2025
@denialhaag denialhaag added continuous integration Anything related to the CI setup MLIR Anything related to MLIR labels Dec 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated build infrastructure dependencies to maintain compatibility with current tooling versions.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Updated the MLIR setup step in the reusable CI workflow to use a newer external action version (setup-mlir) with an updated LLVM version parameter (21.1.7), replacing the previous action reference and its tag-based input. No control flow changes.

Changes

Cohort / File(s) Change Summary
CI Workflow Configuration
\.github/workflows/reusable-mlir-tests.yml``
Updated "Set up MLIR" step to use newer setup-mlir action version (6b8d4ef) with llvm-version: 21.1.7 input instead of previous version with tag: 2025.11.25 parameter

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single workflow file with straightforward action reference and parameter update
  • No logic or control flow changes involved

Possibly related PRs

Suggested reviewers

  • burgholzer

Poem

🐰 A version bump hops into view,
Twenty-one point seven, fresh and new!
MLIR action steps into place,
Workflows run at a faster pace! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating the setup-mlir version, which matches the PR's core objective.
Description check ✅ Passed The description includes a summary of changes and a completed checklist, though some checklist items are appropriately marked as not applicable for this infrastructure update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test-setup-mlir

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@denialhaag denialhaag marked this pull request as draft December 4, 2025 22:17
@denialhaag denialhaag changed the title 👷 Test new version of setup-mlir 👷 Update setup-mlir version Dec 5, 2025
@denialhaag denialhaag added the dependencies Pull requests that update a dependency file label Dec 5, 2025
@denialhaag denialhaag marked this pull request as ready for review December 5, 2025 17:25
@denialhaag denialhaag requested a review from burgholzer December 5, 2025 17:25
@denialhaag
Copy link
Member Author

I guess we might as well use this PR to get ahead of the inevitable Renovate PR.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Sounds good 👍🏼

@burgholzer burgholzer added this to the MLIR Support milestone Dec 5, 2025
@denialhaag denialhaag enabled auto-merge (squash) December 5, 2025 17:32
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02fda43 and 6a6e591.

📒 Files selected for processing (1)
  • .github/workflows/reusable-mlir-tests.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/reusable-mlir-tests.yml (1)

40-43: Action version update verified and parameters are correct. The commit hash 6b8d4ef561ca19268764609adf9fa12f53015e1f is confirmed in the setup-mlir repository, tagged as 2025.12.05, the llvm-version parameter is supported in the action's API, and LLVM 21.1.7 is a valid release (released Dec 2, 2025, used by the 2025.12.05 release build).

@denialhaag denialhaag merged commit fa51641 into main Dec 5, 2025
30 checks passed
@denialhaag denialhaag deleted the test-setup-mlir branch December 5, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file MLIR Anything related to MLIR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants