fix: gap analysis fixes - TLS misclassification, --redact, spec update#4
Merged
Conversation
…ign spec ## Changes ### Bug Fix: TLS_CERT_NOT_YET_VALID - Separated TLS_CERT_NOT_YET_VALID from TLS_CERT_EXPIRED (was misclassified) - Added isCertNotYetValid() to distinguish "is before" vs "is after" messages - Added NotBefore check in success path for insecure mode (returns warn) - 5 new TLS tests covering all expired/not-yet-valid/insecure combinations ### Feature: --redact flag - Added --redact (default ON) and --no-redact CLI flags - Added Redact field to Config and ProbeContext - 6 new unit tests + 2 E2E tests for flag parsing - Actual masking logic is a follow-up task ### Design Spec Update (product-design.md) - JSON schema aligned to implementation (layer-nested observations, duration_ms) - Codes table: added fallback codes (*_ERROR), TLS_CERT_NOT_YET_VALID, HTTP_500 - Added error code normalization rules - CLI scope clarified: --redact=MVP, --count=v0.2, --verbose/dns://=Phase 1 - Timing policy documented: common duration_ms + HTTP ttfb/total optional ### Docs - Added Agent Teams usage guide (docs/agent-teams-guide.md) ## Codex Review - Test cases reviewed by Codex before implementation (TDD) - Gap analysis conducted with structured Codex discussion - All decisions are Claude-Codex consensus Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detail
TLS_CERT_NOT_YET_VALID (バグ修正)
classifyTLSError()が "not yet valid" をTLS_CERT_EXPIREDに誤分類していたisCertNotYetValid()追加、insecureモードではwarn返却--redact (新機能)
--no-redactで無効化可能（BoolVar, default false → Redact=!noRedact）設計ドキュメント (product-design.md)
Test plan
go test ./...ALL PASSMemo (振り返り用)
🤖 Generated with Claude Code