Support README build instructions on FreeBSD#17886
Merged
Merged
Conversation
jsm222
commented
Jun 6, 2023
jsm222
commented
Contributor
Rename files with spaces because bmake does not understand escaped spaces. And set MUE_BUILD_CRASHPAD_CLIENT to OFF on FreeBSD.
igorkorsukov
reviewed
Jun 7, 2023
| option(MUE_BUILD_CRASHPAD_CLIENT "Build crashpad client" ON) | ||
| set(MUE_CRASH_REPORT_URL "" CACHE STRING "URL where to send crash reports") | ||
| option(MUE_CRASHPAD_HANDLER_PATH "Path to custom crashpad_handler executable (optional)" "") | ||
| endif() |
Member
There was a problem hiding this comment.
Please do it here https://github.com/musescore/MuseScore/blob/master/SetupConfigure.cmake#L104
like:
if (OS_IS_FBSD)
message(WARNING "...")
set(MUE_BUILD_CRASHPAD_CLIENT OFF)
endif()
igorkorsukov
approved these changes
Jun 7, 2023
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 7, 2023
…aces. Partial backport of musescore#17886
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 10, 2023
…aces. Partial backport of musescore#17886
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 16, 2023
…aces. Partial backport of musescore#17886
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 5, 2023
…aces. Partial backport of musescore#17886
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.