Skip to content

measure_repeats_and_dynamics#20598

Merged
RomanPudashkin merged 3 commits into
musescore:masterfrom
RomanPudashkin:measure_repeats_and_dynamics
Apr 24, 2024
Merged

measure_repeats_and_dynamics#20598
RomanPudashkin merged 3 commits into
musescore:masterfrom
RomanPudashkin:measure_repeats_and_dynamics

Conversation

@RomanPudashkin

@RomanPudashkin RomanPudashkin commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

Resolves: #15232
Resolves: #17680

@cbjeukendrup

Copy link
Copy Markdown
Collaborator

In this case:
Scherm­afbeelding 2023-12-20 om 18 01 26
The measure with measure repeat starts ppp, but shouldn't it start fff?
I think this is a debatable case... not sure what the expected behaviour should be.

Comment thread src/engraving/playback/playbackcontext.cpp Outdated
@RomanPudashkin
RomanPudashkin force-pushed the measure_repeats_and_dynamics branch from cdb5552 to 0865afc Compare December 20, 2023 19:12
Comment thread src/engraving/playback/playbackcontext.cpp Outdated
Comment thread src/engraving/playback/playbackcontext.cpp Outdated
@cbjeukendrup

Copy link
Copy Markdown
Collaborator

Shouldn't we do the same for playing techniques? (Possibly as a separate issue/PR)

@RomanPudashkin
RomanPudashkin force-pushed the measure_repeats_and_dynamics branch 2 times, most recently from a599175 to fad4678 Compare December 21, 2023 09:44
@DmitryArefiev

Copy link
Copy Markdown
Contributor

Tested on Win10. There are some issues:

  1. 4 measure repeats don't work correctly
bandicam.2023-12-29.18-40-55-292.mp4
  1. Strange thing, 1 measure repeats stop working after adding repeat barlines before
bandicam.2023-12-29.18-52-11-015.mp4

@igorkorsukov
igorkorsukov force-pushed the master branch 6 times, most recently from fa1f8d3 to 525a11a Compare February 14, 2024 09:08
@RomanPudashkin
RomanPudashkin force-pushed the measure_repeats_and_dynamics branch 2 times, most recently from f62f0d5 to e7c31ad Compare April 23, 2024 06:27
@DmitryArefiev

DmitryArefiev commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

Tested on Win10.

Strange thing, 1 measure repeats stop working after adding repeat barlines before

This still occurs

bandicam.2024-04-23.17-12-05-839.mp4

Attaching the scores Scores.zip

@RomanPudashkin
RomanPudashkin force-pushed the measure_repeats_and_dynamics branch from e7c31ad to 4d986cc Compare April 24, 2024 09:43
@DmitryArefiev

DmitryArefiev commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Tested #15232 #17680 on Win10, Mac13.6 - FIXED

This case #20598 (comment) is also fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Repeat last bar" symbol doesn't repeat pizzicato and arco instructions [MU4 Issue] Measure repeats ignore dynamics

3 participants